[NFC][VPlan] Simplify VPValue::removeUser

[sunshaoce]

I think we don't need to use lambda, and we can end the loop in advance like this.

[llvmbot]

@llvm/pr-subscribers-llvm-transforms

Author: Shao-Ce SUN (sunshaoce)

Changes

I think we don't need to use lambda, and we can end the loop in advance like this.

---

Full diff: https://github.com/llvm/llvm-project/pull/74708.diff

1 Files Affected:

• (modified) llvm/lib/Transforms/Vectorize/VPlanValue.h (+5-9)

diff --git a/llvm/lib/Transforms/Vectorize/VPlanValue.h b/llvm/lib/Transforms/Vectorize/VPlanValue.h
index ac2883b30dc8c..14634dc31878f 100644
--- a/llvm/lib/Transforms/Vectorize/VPlanValue.h
+++ b/llvm/lib/Transforms/Vectorize/VPlanValue.h
@@ -121,18 +121,14 @@ class VPValue {
 
   /// Remove a single \p User from the list of users.
   void removeUser(VPUser &User) {
-    bool Found = false;
     // The same user can be added multiple times, e.g. because the same VPValue
     // is used twice by the same VPUser. Remove a single one.
-    erase_if(Users, [&User, &Found](VPUser *Other) {
-      if (Found)
-        return false;
-      if (Other == &User) {
-        Found = true;
-        return true;
+    for (const auto &U : Users) {
+      if (U == &User) {
+        Users.erase(&U);
+        return;
       }
-      return false;
-    });
+    }
   }
 
   typedef SmallVectorImpl<VPUser *>::iterator user_iterator;

[topperc]

LGTM

[fhahn]

LGTM, thanks.

Please see the inline comment before merging and also adjust the commit messages to be definitive, i.e. drop It think and adjust to say hat this is now using find + erase; there's no more explicit loop.