Skip to content

[mlir][ArmSME] Update -allocate-arm-sme-tiles description (NFC) #74871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

MacDue
Copy link
Member

@MacDue MacDue commented Dec 8, 2023

No description provided.

@MacDue MacDue requested a review from c-rhodes December 8, 2023 17:20
@MacDue MacDue marked this pull request as ready for review December 8, 2023 17:22
@llvmbot
Copy link
Member

llvmbot commented Dec 8, 2023

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-sme

Author: Benjamin Maxwell (MacDue)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/74871.diff

1 Files Affected:

  • (modified) mlir/include/mlir/Dialect/ArmSME/Transforms/Passes.td (+3-2)
diff --git a/mlir/include/mlir/Dialect/ArmSME/Transforms/Passes.td b/mlir/include/mlir/Dialect/ArmSME/Transforms/Passes.td
index 7b9c74e0b8f60e..02238f0a18bab9 100644
--- a/mlir/include/mlir/Dialect/ArmSME/Transforms/Passes.td
+++ b/mlir/include/mlir/Dialect/ArmSME/Transforms/Passes.td
@@ -87,8 +87,9 @@ def TileAllocation
   let summary = "Allocate SME tiles";
   let description = [{
     This pass does tile allocation for SME "virtual tiles". It is run at the
-    'func.func' op level, replacing 'arm_sme.get_tile_id' ops with (i32) tile
-    ids. An error will be emitted when there's no tiles left.
+    'func.func' op level, and assigns tile IDs (via an attribute) to all ops
+    that implement the `ArmSMETileOpInterface`. An error will be emitted when
+    there's no tiles left.
   }];
   let constructor = "mlir::arm_sme::createTileAllocationPass()";
   let dependentDialects = ["func::FuncDialect"];

@MacDue MacDue merged commit a176710 into llvm:main Dec 9, 2023
@MacDue MacDue deleted the doc_update branch December 9, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants