[SPIR-V][NFC] Require asserts on 2 tests #75087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests currently fail on asserts, so adding a REQUIRES to make sure they're skipped on builds with asserts disabled. Follow-up from llvm#74849
|
@llvm/pr-subscribers-backend-spir-v Author: Natalie Chouinard (sudonatalie) ChangesThese tests currently fail on asserts, so adding a REQUIRES to make sure they're skipped on builds with asserts disabled. Follow-up from #74849 Full diff: https://github.com/llvm/llvm-project/pull/75087.diff 2 Files Affected:
diff --git a/llvm/test/CodeGen/SPIRV/opencl/device_execution/execute_block.ll b/llvm/test/CodeGen/SPIRV/opencl/device_execution/execute_block.ll
index b001ce09f5679..1df72dc734dbd 100644
--- a/llvm/test/CodeGen/SPIRV/opencl/device_execution/execute_block.ll
+++ b/llvm/test/CodeGen/SPIRV/opencl/device_execution/execute_block.ll
@@ -2,6 +2,7 @@
; TODO(#60133): Requires updates following opaque pointer migration.
; XFAIL: *
+; REQUIRES: asserts
; CHECK: %[[#bool:]] = OpTypeBool
; CHECK: %[[#true:]] = OpConstantTrue %[[#bool]]
diff --git a/llvm/test/CodeGen/SPIRV/transcoding/BuildNDRange_2.ll b/llvm/test/CodeGen/SPIRV/transcoding/BuildNDRange_2.ll
index 75aa87f958d47..a2ae808259a32 100644
--- a/llvm/test/CodeGen/SPIRV/transcoding/BuildNDRange_2.ll
+++ b/llvm/test/CodeGen/SPIRV/transcoding/BuildNDRange_2.ll
@@ -22,6 +22,7 @@
; TODO(#60133): Requires updates following opaque pointer migration.
; XFAIL: *
+; REQUIRES: asserts
; CHECK-SPIRV-DAG: %[[#LEN2_ID:]] = OpConstant %[[#]] 2
; CHECK-SPIRV-DAG: %[[#LEN3_ID:]] = OpConstant %[[#]] 3
|
|
Since we merged #74849 , the SPIR-V Tests buildbot should pass now with or without this change, but adding this quick follow-up to make the test requirements more explicit anyways. |
michalpaszkowski
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests currently fail on asserts, so adding a REQUIRES to make sure they're skipped on builds with asserts disabled.
Follow-up from #74849