[mlir][docs] Fix a broken passes documentation #77402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sott0n
requested review from
banach-space,
dcaballe and
nicolasvasilache
as code owners
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-sve Author: Kohei Yamaguchi (sott0n) Changes
Full diff: https://github.com/llvm/llvm-project/pull/77402.diff 2 Files Affected:
diff --git a/mlir/docs/Passes.md b/mlir/docs/Passes.md
index 66e2dc077f9854..ee7d47cc022723 100644
--- a/mlir/docs/Passes.md
+++ b/mlir/docs/Passes.md
@@ -40,6 +40,10 @@ This document describes the available MLIR passes and their contracts.
[include "AsyncPasses.md"]
+## 'emitc' Dialect Passes
+
+[include "EmitCPasses.md"]
+
## 'func' Dialect Passes
[include "FuncPasses.md"]
diff --git a/mlir/include/mlir/Dialect/ArmSVE/Transforms/Passes.td b/mlir/include/mlir/Dialect/ArmSVE/Transforms/Passes.td
index d7cb309db5253e..b9b06cec1f9779 100644
--- a/mlir/include/mlir/Dialect/ArmSVE/Transforms/Passes.td
+++ b/mlir/include/mlir/Dialect/ArmSVE/Transforms/Passes.td
@@ -21,7 +21,7 @@ def LegalizeVectorStorage
This pass currently addresses two issues.
- ## Loading and storing predicate types
+ #### Loading and storing predicate types
It is only legal to load/store predicate types equal to (or greater than) a
full predicate register, which in MLIR is `vector<[16]xi1>`. Smaller
@@ -49,7 +49,7 @@ def LegalizeVectorStorage
%reload = arm_sve.convert_from_svbool %reload_svbool : vector<[4]xi1>
```
- ## Relax alignments for SVE vector allocas
+ #### Relax alignments for SVE vector allocas
The storage for SVE vector types only needs to have an alignment that
matches the element type (for example 4 byte alignment for `f32`s). However,
|
banach-space
reviewed
Jan 9, 2024
banach-space
approved these changes
Jan 9, 2024
MacDue
approved these changes
Jan 9, 2024
MacDue
approved these changes
Jan 9, 2024
|
@banach-space @MacDue Thank you for your review! Could you land it? |
Sure 👍 |
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
- Add EmitC passes into Pass.md - Modify header level of the pass description to under the `LegalizeVectorStorage` pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LegalizeVectorStoragepass