[Flang][Parser] Add missing #include "flang/Common/idioms.h" #77484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file format-specification.h uses definitions from Fortran::common, but doesn't include any headers that provide them.
llvmbot
added
flang
|
@llvm/pr-subscribers-flang-parser Author: Krzysztof Parzyszek (kparzysz) ChangesThe file format-specification.h uses definitions from Fortran::common, but doesn't include any headers that provide them. Full diff: https://github.com/llvm/llvm-project/pull/77484.diff 1 Files Affected:
diff --git a/flang/include/flang/Parser/format-specification.h b/flang/include/flang/Parser/format-specification.h
index a34e68af2832f3..82bc995a93c484 100644
--- a/flang/include/flang/Parser/format-specification.h
+++ b/flang/include/flang/Parser/format-specification.h
@@ -18,6 +18,8 @@
// dependences on other parts of the compiler's source code.
// TODO: support Q formatting extension?
+#include "flang/Common/idioms.h"
+
#include <cinttypes>
#include <list>
#include <optional>
|
kparzysz
requested review from
clementval,
skatrak,
kiranchandramohan and
jeanPerier
jeanPerier
approved these changes
Jan 10, 2024
| @@ -18,6 +18,8 @@ | |||
| // dependences on other parts of the compiler's source code. | |||
| // TODO: support Q formatting extension? | |||
|
|
|||
| #include "flang/Common/idioms.h" | |||
|
|
|||
There was a problem hiding this comment.
flang frontend headers do not add blank lines between user and system headers.
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file format-specification.h uses definitions from Fortran::common, but doesn't include any headers that provide them.