Skip to content

Conversation

alanzhao1
Copy link
Contributor

This test was originally introduced in
#76976, but it incorrectly tests braced-list initialization instead of parenthesized initialization.

This test was originally introduced in
llvm#76976, but it incorrectly
tests braced-list initialization instead of parenthesized
initialization.
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Jan 23, 2024
@llvmbot
Copy link
Member

llvmbot commented Jan 23, 2024

@llvm/pr-subscribers-clang

Author: Alan Zhao (alanzhao1)

Changes

This test was originally introduced in
#76976, but it incorrectly tests braced-list initialization instead of parenthesized initialization.


Full diff: https://github.com/llvm/llvm-project/pull/79225.diff

1 Files Affected:

  • (modified) clang/test/CodeGenCXX/new-array-init.cpp (+1-1)
diff --git a/clang/test/CodeGenCXX/new-array-init.cpp b/clang/test/CodeGenCXX/new-array-init.cpp
index fe1bdf425ab142f..781c4728df45095 100644
--- a/clang/test/CodeGenCXX/new-array-init.cpp
+++ b/clang/test/CodeGenCXX/new-array-init.cpp
@@ -164,7 +164,7 @@ void string_sufficient_paren() {
   // FIXME: For very large arrays, it would be preferable to emit a small copy and a memset.
   // CHECKCXX20: call void @llvm.memcpy{{.*}}(ptr align {{[0-9]+}} %[[PTR]], ptr align {{[0-9]+}} @[[ABC15]], i32 15,
   // CHECKCXX20-NOT: memset
-  new char[15] { "abc" };
+  new char[15]("abc");
 }
 #endif
 

@alanzhao1 alanzhao1 merged commit 25e1916 into llvm:main Jan 23, 2024
@alanzhao1 alanzhao1 deleted the bugfix/fix-test branch January 23, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants