Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix running-a-pass-with-opt in doc #79273

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

LukeLIN-web
Copy link

@LukeLIN-web LukeLIN-web commented Jan 24, 2024

In https://llvm.org/docs/WritingAnLLVMNewPMPass.html#running-a-pass-with-opt

We need to put HelloWorld.cpp to add_llvm_component_library in the
llvm/lib/Transforms/Utils/CMakeLists.txt file. This will ensure that the
pass is built and linked into opt.

Otherwise it will lead to ld: Undefined symbols

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@LukeLIN-web LukeLIN-web changed the title fix CMakeLists.txt in doc [Docs] Fix CMakeLists.txt in doc Jan 24, 2024
@LukeLIN-web LukeLIN-web changed the title [Docs] Fix CMakeLists.txt in doc [Docs] Fix running-a-pass-with-opt in doc Jan 24, 2024
@LukeLIN-web LukeLIN-web marked this pull request as draft January 24, 2024 15:22
@LukeLIN-web LukeLIN-web marked this pull request as ready for review January 24, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant