Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[builtins] Update HAVE_SYSCONF configure check to adapt CMake #79847

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[builtins] Update HAVE_SYSCONF configure check to adapt CMake #79847

wants to merge 1 commit into from

Conversation

piggynl
Copy link
Member

@piggynl piggynl commented Jan 29, 2024

The cleans up the HAVE_SYSCONF check in enable_execute_stack.c from 2dbae9c and 40268af. Those two commits were made when the CMake build system was not ready yet.

@piggynl piggynl requested a review from compnerd January 29, 2024 15:20
@piggynl piggynl marked this pull request as draft January 29, 2024 15:28
@piggynl
[builtins] Update HAVE_SYSCONF configure check to adapt CMake
17103cc 
The cleans up the HAVE_SYSCONF check in enable_execute_stack.c from
2dbae9c and 40268af. Those two commits were made when the CMake build
system was not ready yet.
@piggynl piggynl changed the title [builtins] Update HAVE_SYSCONF configure check to adapt CMake [NFC] [builtins] Update HAVE_SYSCONF configure check to adapt CMake Jan 29, 2024
@piggynl piggynl marked this pull request as ready for review January 29, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd Awaiting requested review from compnerd

@petrhosek petrhosek Awaiting requested review from petrhosek

Assignees
No one assigned
Labels
compiler-rt:builtins compiler-rt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@piggynl @llvmbot