Skip to content

[flang] Introducing a method to dynamically and conditionally register dialect interfaces. #80794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

VijayKandiah
Copy link
Contributor

This change introduces the addFIRExtensions method to dynamically and conditionally register dialect interfaces. As a use case of addFIRExtensions, this change moves the static registration of FIRInlinerInterface out of the constructor of FIROpsDialect to be dynamically registered while loading the necessary MLIR dialects required by Flang. This registration of FIRInlinerInterface is also guarded by a boolean addFIRInlinerInterface which defaults to true.

Copy link

github-actions bot commented Feb 6, 2024

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@VijayKandiah VijayKandiah deleted the vk-firinliner-refactor branch February 6, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant