[llvm-objdump] Add support for the PT_OPENBSD_SYSCALLS segment type. #82121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-llvm-binary-utilities Author: Frederic Cambus (fcambus) ChangesReference: https://github.com/openbsd/src/blob/master/sys/sys/exec_elf.h Full diff: https://github.com/llvm/llvm-project/pull/82121.diff 2 Files Affected:
diff --git a/llvm/test/tools/llvm-objdump/openbsd-headers.test b/llvm/test/tools/llvm-objdump/openbsd-headers.test
index f547854feeeedf..84fa59bdf89f5c 100644
--- a/llvm/test/tools/llvm-objdump/openbsd-headers.test
+++ b/llvm/test/tools/llvm-objdump/openbsd-headers.test
@@ -11,6 +11,8 @@
# CHECK-NEXT: filesz 0x0000000000000000 memsz 0x0000000000000000 flags ---
# CHECK-NEXT: OPENBSD_NOBTCFI off 0x0000000000000000 vaddr 0x0000000000000000 paddr 0x0000000000000000 align 2**0
# CHECK-NEXT: filesz 0x0000000000000000 memsz 0x0000000000000000 flags ---
+# CHECK-NEXT: OPENBSD_SYSCALLS off 0x0000000000000000 vaddr 0x0000000000000000 paddr 0x0000000000000000 align 2**0
+# CHECK-NEXT: filesz 0x0000000000000000 memsz 0x0000000000000000 flags ---
# CHECK-NEXT: OPENBSD_BOOTDATA off 0x0000000000000000 vaddr 0x0000000000000000 paddr 0x0000000000000000 align 2**0
# CHECK-NEXT: filesz 0x0000000000000000 memsz 0x0000000000000000 flags ---
@@ -25,4 +27,5 @@ ProgramHeaders:
- Type: 0x65a3dbe6 ## PT_OPENBSD_RANDOMIZE
- Type: 0x65a3dbe7 ## PT_OPENBSD_WXNEEDED
- Type: 0x65a3dbe8 ## PT_OPENBSD_NOBTCFI
+ - Type: 0x65a3dbe9 ## PT_OPENBSD_SYSCALLS
- Type: 0x65a41be6 ## PT_OPENBSD_BOOTDATA
diff --git a/llvm/tools/llvm-objdump/ELFDump.cpp b/llvm/tools/llvm-objdump/ELFDump.cpp
index 34861ee92128fd..ea91cdb5d7f3e8 100644
--- a/llvm/tools/llvm-objdump/ELFDump.cpp
+++ b/llvm/tools/llvm-objdump/ELFDump.cpp
@@ -288,6 +288,9 @@ template <class ELFT> void ELFDumper<ELFT>::printProgramHeaders() {
case ELF::PT_OPENBSD_NOBTCFI:
outs() << "OPENBSD_NOBTCFI ";
break;
+ case ELF::PT_OPENBSD_SYSCALLS:
+ outs() << "OPENBSD_SYSCALLS ";
+ break;
case ELF::PT_OPENBSD_RANDOMIZE:
outs() << "OPENBSD_RANDOMIZE ";
break;
|
brad0
approved these changes
Feb 17, 2024
MaskRay
reviewed
Feb 18, 2024
llvm/tools/llvm-objdump/ELFDump.cpp
Outdated
| @@ -288,6 +288,9 @@ template <class ELFT> void ELFDumper<ELFT>::printProgramHeaders() { | |||
| case ELF::PT_OPENBSD_NOBTCFI: | |||
| outs() << "OPENBSD_NOBTCFI "; | |||
| break; | |||
| case ELF::PT_OPENBSD_SYSCALLS: | |||
There was a problem hiding this comment.
This seems sorted alphabetically.
MaskRay
approved these changes
Feb 18, 2024
fcambus
force-pushed
the
llvm-objdump
branch
from
3952bf0
to
cca318b
Compare
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Feb 20, 2024
…lvm#82121) Reference: https://github.com/openbsd/src/blob/master/sys/sys/exec_elf.h (cherry picked from commit 1b89486)
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Feb 20, 2024
…lvm#82121) Reference: https://github.com/openbsd/src/blob/master/sys/sys/exec_elf.h (cherry picked from commit 1b89486)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://github.com/openbsd/src/blob/master/sys/sys/exec_elf.h