Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOLT][DWARF][NFC] Use SkeletonCU in place of IsDWO check #82540

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

ayermolo
Copy link
Contributor

Changed isDWO to a function that checks Skeleton CU that is passed in. This is for preparation for #81062.

Changed isDWO to a function that checks Skeleton CU that is passed in. This is
for preparation for llvm#81062.
@ayermolo ayermolo added the BOLT label Feb 21, 2024
Copy link

github-actions bot commented Feb 21, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

@ayermolo ayermolo changed the title [BOLT][DWARF] CHange isDWO [BOLT][DWARF] Change isDWO Feb 21, 2024
Copy link
Contributor

@aaupov aaupov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG but please retitle to something like "[BOLT][DWARF][NFC] Use SkeletonCU in place of IsDWO check" so it's clear from the title what's going on.

@ayermolo ayermolo changed the title [BOLT][DWARF] Change isDWO [BOLT][DWARF][NFC] Use SkeletonCU in place of IsDWO check Feb 22, 2024
@ayermolo ayermolo merged commit 640e781 into llvm:main Feb 22, 2024
5 checks passed
@ayermolo ayermolo deleted the IsDWO branch February 22, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants