[llvm][doc][cmake] Use llvm_config instead of llvm_map_components_to_libnames (llvm#34593) #82769
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #34593.
llvm_map_components_to_libnames
can not handle LLVM builds withLLVM_LINK_LLVM_DYLIB
. And it's recommended to use llvm_config instead.However, I question the necessity of checking
USE_SHARED
withinllvm_config
. As I can't envision scenarios whereUSE_SHARED
is not desired by users ( which is equivalent to directly callingexplicit_llvm_config
). See foutrelis' comment.Given this, I propose combining
llvm_config
andexplicit_llvm_config
into one. But this will makes another PR and I'm not sure how to thoroughly test such a change.closes #34593 closes #82266