Skip to content

Conversation

FurryAcetylCoA
Copy link

As discussed in #34593. llvm_map_components_to_libnames can not handle LLVM builds with LLVM_LINK_LLVM_DYLIB. And it's recommended to use llvm_config instead.

However, I question the necessity of checking USE_SHARED within llvm_config. As I can't envision scenarios where USE_SHARED is not desired by users ( which is equivalent to directly calling explicit_llvm_config). See foutrelis' comment.
Given this, I propose combining llvm_config and explicit_llvm_config into one. But this will makes another PR and I'm not sure how to thoroughly test such a change.

closes #34593 closes #82266

…libnames (#34593)

 llvm_map_components_to_libnames can not handle llvm built with
 LLVM_LINK_LLVM_DYLIB.
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Embedding LLVM in your project" needs an update. llvm_map_components_to_libnames and llvm_config do not work with LLVM_LINK_LLVM_DYLIB=ON
1 participant