[libc] fix typo introduced in inline_bcmp_byte_per_byte #83356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My global find+replace was overzealous and broke post submit unit tests. Link: llvm#83345
|
@llvm/pr-subscribers-libc Author: Nick Desaulniers (nickdesaulniers) ChangesMy global find+replace was overzealous and broke post submit unit tests. Link: #83345 Full diff: https://github.com/llvm/llvm-project/pull/83356.diff 1 Files Affected:
diff --git a/libc/src/string/memory_utils/generic/byte_per_byte.h b/libc/src/string/memory_utils/generic/byte_per_byte.h
index 948da8ab2a8702..9515398794df40 100644
--- a/libc/src/string/memory_utils/generic/byte_per_byte.h
+++ b/libc/src/string/memory_utils/generic/byte_per_byte.h
@@ -56,7 +56,7 @@ inline_bcmp_byte_per_byte(CPtr p1, CPtr p2, size_t count, size_t offset = 0) {
LIBC_LOOP_NOUNROLL
for (; offset < count; ++offset)
if (p1[offset] != p2[offset])
- return BcmpReturnType::zero();
+ return BcmpReturnType::nonzero();
return BcmpReturnType::zero();
}
|
nickdesaulniers
referenced
this pull request
Feb 29, 2024
Codify that we use lower_case for readability-identifier-naming.ConstexprFunctionCase and then fix the 11 violations (rather than codify UPPER_CASE and have to fix the 170 violations).
michaelrj-google
approved these changes
Feb 29, 2024
|
Can someone merge this for me? Will be offline for a bit.
…On Wed, Feb 28, 2024, 4:20 PM Michael Jones ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#83356 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN5IXZQ7WWZEGZTZD5C3L3YV7CTTAVCNFSM6AAAAABD66MHCKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMBXGY4TGNRYGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
mylai-mtk
pushed a commit
to mylai-mtk/llvm-project
that referenced
this pull request
Jul 12, 2024
My global find+replace was overzealous and broke post submit unit tests. Link: llvm#83345
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My global find+replace was overzealous and broke post submit unit tests.
Link: #83345