Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TableGen] Bug fix for tied optional operands resolution #83588

Conversation

AlfieRichardsArm
Copy link
Contributor

This fixes tied operand resolution when there are optional operands before it.

@AlfieRichardsArm
Copy link
Contributor Author

@s-barannikov Pulled this bug fix out as a separate patch

Copy link
Contributor

@s-barannikov s-barannikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a FIXME near OpIdx calculation that it is not an operand index in CVT_Tied case?

llvm/utils/TableGen/AsmMatcherEmitter.cpp Outdated Show resolved Hide resolved
llvm/utils/TableGen/AsmMatcherEmitter.cpp Outdated Show resolved Hide resolved
@AlfieRichardsArm AlfieRichardsArm force-pushed the fix-pseudo-operands-tied-resolution branch from 0d58b59 to ac16abb Compare March 14, 2024 09:15
@AlfieRichardsArm AlfieRichardsArm merged commit 3128c20 into llvm:main Mar 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants