[mlir][IR][NFC] Make replaceAllUsesWith non-templatized

[matthias-springer]

Turn RewriterBase::replaceAllUsesWith into a non-templatized implementation, so that it can be made virtual and be overridden in the ConversionPatternRewriter in a subsequent change.

This change is in preparation of adding dialect conversion support for replaceAllUsesWith.

[llvmbot]

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-core

Author: Matthias Springer (matthias-springer)

Changes

Turn RewriterBase::replaceAllUsesWith into a non-templatized implementation, so that it can be made virtual and be overridden in the ConversionPatternRewriter in a subsequent change.

This change is in preparation of adding dialect conversion support for replaceAllUsesWith.

---

Full diff: https://github.com/llvm/llvm-project/pull/84722.diff

1 Files Affected:

• (modified) mlir/include/mlir/IR/PatternMatch.h (+6-4)

diff --git a/mlir/include/mlir/IR/PatternMatch.h b/mlir/include/mlir/IR/PatternMatch.h
index c1408c3f90a53b..2be1e2e2b40276 100644
--- a/mlir/include/mlir/IR/PatternMatch.h
+++ b/mlir/include/mlir/IR/PatternMatch.h
@@ -615,11 +615,13 @@ class RewriterBase : public OpBuilder {
   /// Find uses of `from` and replace them with `to`. Also notify the listener
   /// about every in-place op modification (for every use that was replaced).
   void replaceAllUsesWith(Value from, Value to) {
-    return replaceAllUsesWith(from.getImpl(), to);
+    for (OpOperand &operand : llvm::make_early_inc_range(from.getUses())) {
+      Operation *op = operand.getOwner();
+      modifyOpInPlace(op, [&]() { operand.set(to); });
+    }
   }
-  template <typename OperandType, typename ValueT>
-  void replaceAllUsesWith(IRObjectWithUseList<OperandType> *from, ValueT &&to) {
-    for (OperandType &operand : llvm::make_early_inc_range(from->getUses())) {
+  void replaceAllUsesWith(Block *from, Block *to) {
+    for (BlockOperand &operand : llvm::make_early_inc_range(from->getUses())) {
       Operation *op = operand.getOwner();
       modifyOpInPlace(op, [&]() { operand.set(to); });
     }

[ingomueller-net]

Yeah, makes sense. I have contemplated that possibility already when I added the templated version.