[Orc] Move SymbolStringPool from EPC to ExecutionSession (NFC) #85056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
weliveindetail
commented
Mar 13, 2024
| @@ -1453,7 +1453,8 @@ class ExecutionSession { | |||
|
|
|||
| /// Construct an ExecutionSession with the given ExecutorProcessControl | |||
| /// object. | |||
| ExecutionSession(std::unique_ptr<ExecutorProcessControl> EPC); | |||
| ExecutionSession(std::unique_ptr<ExecutorProcessControl> EPC, | |||
| std::shared_ptr<SymbolStringPool> SSP = nullptr); | |||
There was a problem hiding this comment.
If we keep the default value here, we don't need the second patch. It would reduce the PR size significantly: 23a9ec6
I am not sure though, do we want default values in the public headers?
|
Test failures from pre-merge checks are unrelated |
|
From the upstream code-base's point of view this patch makes total sense. For downstream users, the issue is that we don't have an extension point for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExecutorProcessControl's interface is supposed to be limited, but over time it accumulated some weight. This is a first attempt to sort things out. Moving ownership of theSymbolStringPoolfromExecutorProcessControltoExecutionSessionhas no functional impact. It only changes the interface.