Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing clang to the monolithic pre-merge build #85354

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

joker-eph
Copy link
Collaborator

Clang has a custom separate pipeline integrated with libc++ that only runs in release mode. It means that changes which touches only clang won't run the clang tests in the configuration used by LLVM premerge and will break it unknowingly.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Mar 15, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Mar 15, 2024

@llvm/pr-subscribers-clang

Author: Mehdi Amini (joker-eph)

Changes

Clang has a custom separate pipeline integrated with libc++ that only runs in release mode. It means that changes which touches only clang won't run the clang tests in the configuration used by LLVM premerge and will break it unknowingly.


Full diff: https://github.com/llvm/llvm-project/pull/85354.diff

2 Files Affected:

  • (modified) .ci/generate-buildkite-pipeline-premerge (+1-1)
  • (added) clang/empty_trigger ()
diff --git a/.ci/generate-buildkite-pipeline-premerge b/.ci/generate-buildkite-pipeline-premerge
index 4ebf304e23d587..b0a995dc8d7df4 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -224,7 +224,7 @@ fi
 # needs while letting them run on the infrastructure provided by LLVM.
 
 # Figure out which projects need to be built on each platform
-all_projects="bolt clang-tools-extra compiler-rt cross-project-tests flang libc libclc lld lldb llvm mlir openmp polly pstl"
+all_projects="bolt clang clang-tools-extra compiler-rt cross-project-tests flang libc libclc lld lldb llvm mlir openmp polly pstl"
 modified_projects="$(keep-modified-projects ${all_projects})"
 
 linux_projects_to_test=$(exclude-linux $(compute-projects-to-test ${modified_projects}))
diff --git a/clang/empty_trigger b/clang/empty_trigger
new file mode 100644
index 00000000000000..e69de29bb2d1d6

Copy link
Collaborator

@tstellar tstellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

Clang has a custom separate pipeline integrated with libc++
that only runs in release mode. It means that changes which touches
only clang won't run the clang tests in the configuration used by
LLVM premerge and will break it unknowingly.
@joker-eph joker-eph merged commit d35f944 into llvm:main Mar 15, 2024
4 checks passed
@joker-eph joker-eph deleted the clang-premerge branch March 15, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants