Skip to content

[libc++] Switch FreeBSD CI job to Clang 17 #86320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2024
Merged

[libc++] Switch FreeBSD CI job to Clang 17 #86320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
490441c
[libc++][test] Skip module tests on FreeBSD for now
emaste Mar 25, 2024
661b7dd
[libc++] Switch FreeBSD CI job to Clang 17
emaste Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libcxx/utils/ci/buildkite-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,8 @@ steps:
- label: FreeBSD 13 amd64
command: libcxx/utils/ci/run-buildbot generic-cxx23
Copy link
Contributor

@H-G-Hristov H-G-Hristov Mar 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know.

How about
https://github.com/H-G-Hristov/llvm-project/blob/c05baf241cdf8ca34c3a6f0182487d40eeca8490/libcxx/utils/ci/run-buildbot#L318-L319:
generic-cxx23 -> generic-cxx26?
@mordante is that the correct change?

env:
CC: clang16
CXX: clang++16
CC: clang17
CXX: clang++17
agents:
queue: libcxx-builders
os: freebsd
Expand Down
1 change: 1 addition & 0 deletions libcxx/utils/libcxx/test/features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@ def _getAndroidDeviceApi(cfg):
# This is not allowed per C11 7.1.2 Standard headers/6
# Any declaration of a library function shall have external linkage.
when=lambda cfg: "__ANDROID__" in compilerMacros(cfg)
or "__FreeBSD__" in compilerMacros(cfg)
or "_WIN32" in compilerMacros(cfg)
or platform.system().lower().startswith("aix")
# Avoid building on platforms that don't support modules properly.
Expand Down