Skip to content

[lldb] [ObjectFileMachO] LLVM_COV is not mapped into firmware memory #86359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2024
Merged

[lldb] [ObjectFileMachO] LLVM_COV is not mapped into firmware memory #86359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47bf125
[lldb] [ObjectFileMachO] LLVM_COV is not mapped into firmware memory
jasonmolenda Mar 22, 2024
fe8f26d
Merge branch 'main' into llvm-cov-not-loaded-in-memory-for-firmware
jasonmolenda Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,6 +905,11 @@ ConstString ObjectFileMachO::GetSegmentNameDWARF() {
return g_section_name;
}

ConstString ObjectFileMachO::GetSegmentNameLLVM_COV() {
static ConstString g_section_name("__LLVM_COV");
return g_section_name;
}

ConstString ObjectFileMachO::GetSectionNameEHFrame() {
static ConstString g_section_name_eh_frame("__eh_frame");
return g_section_name_eh_frame;
Expand Down Expand Up @@ -6145,6 +6150,13 @@ bool ObjectFileMachO::SectionIsLoadable(const Section *section) {
return false;
if (GetModule().get() != section->GetModule().get())
return false;
// firmware style binaries with llvm gcov segment do
// not have that segment mapped into memory.
if (section->GetName() == GetSegmentNameLLVM_COV()) {
const Strata strata = GetStrata();
if (strata == eStrataKernel || strata == eStrataRawImage)
return false;
}
// Be careful with __LINKEDIT and __DWARF segments
if (section->GetName() == GetSegmentNameLINKEDIT() ||
section->GetName() == GetSegmentNameDWARF()) {
Expand Down
1 change: 1 addition & 0 deletions lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ class ObjectFileMachO : public lldb_private::ObjectFile {
static lldb_private::ConstString GetSegmentNameOBJC();
static lldb_private::ConstString GetSegmentNameLINKEDIT();
static lldb_private::ConstString GetSegmentNameDWARF();
static lldb_private::ConstString GetSegmentNameLLVM_COV();
static lldb_private::ConstString GetSectionNameEHFrame();

llvm::MachO::dysymtab_command m_dysymtab;
Expand Down