[memprof] Compute CallStackId when deserializing IndexedAllocationInfo #86421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two ways to create in-memory instances of IndexedAllocationInfo -- deserialization of the raw MemProf data and that of the indexed MemProf data. With: commit 74799f4 Author: Kazu Hirata <kazu@google.com> Date: Sat Mar 23 19:50:15 2024 -0700 we compute CallStackId for each call stack in IndexedAllocationInfo while deserializing the raw MemProf data. This patch does the same while deserilizing the indexed MemProf data. As with the patch above, this patch does not add any use of CallStackId yet.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
✅ With the latest revision this PR passed the Python code formatter. |
| endian::readNext<FrameId, llvm::endianness::little, unaligned>(Ptr); | ||
| Node.CallStack.push_back(Id); | ||
| } | ||
| Node.CSId = hashCallStack(Node.CallStack); |
There was a problem hiding this comment.
Will this eventually be replaced by the CSId held in the indexed profile?
There was a problem hiding this comment.
Yes. As we transition from the current version to the next, we will most likely have two deserializers, say IndexedMemProfRecord::deserializeOld and IndexedMemProfRecord::deserializeNew. The new one will obtain CSId directly from the disk.
teresajohnson
approved these changes
Mar 25, 2024
snehasish
approved these changes
Mar 25, 2024
| /*Payload=*/Start + FramePayloadOffset, | ||
| /*Base=*/Start, memprof::FrameLookupTrait())); | ||
|
|
||
| #if EXPENSIVE_CHECKS |
There was a problem hiding this comment.
nit: I think the convention is to use #ifdef which is slightly different in meaning to #if only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two ways to create in-memory instances of
IndexedAllocationInfo -- deserialization of the raw MemProf data and
that of the indexed MemProf data.
With:
commit 74799f4
Author: Kazu Hirata kazu@google.com
Date: Sat Mar 23 19:50:15 2024 -0700
we compute CallStackId for each call stack in IndexedAllocationInfo
while deserializing the raw MemProf data.
This patch does the same while deserilizing the indexed MemProf data.
As with the patch above, this patch does not add any use of
CallStackId yet.