Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XFAIL clang/Driver/test/compress.c on AIX #87269

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Conversation

azhan92
Copy link
Contributor

@azhan92 azhan92 commented Apr 1, 2024

This PR XFAIL's clang/Driver/compress.c on AIX since it requires the LLVM integrated assembler / assembly parser support, which is not available on AIX.

/home/jenkinsWorker/jenkins/workspace/LLVM-Release/release-testing-prototype/llvm/clang18.1.2-final/final/llvm-project/clang/test/Driver/compress.c:19:18: error: CHECK-OPT_GZ: expected string not found in input
// CHECK-OPT_GZ: "--compress-debug-sections=zlib"

@llvmbot llvmbot added clang Clang issues not falling into any other category clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' labels Apr 1, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Apr 1, 2024

@llvm/pr-subscribers-clang-driver

@llvm/pr-subscribers-clang

Author: None (azhan92)

Changes

This PR XFAIL's clang/Driver/compress.c on AIX since it requires the LLVM integrated assembler / assembly parser support, which is not available on AIX.


Full diff: https://github.com/llvm/llvm-project/pull/87269.diff

1 Files Affected:

  • (modified) clang/test/Driver/compress.c (+4)
diff --git a/clang/test/Driver/compress.c b/clang/test/Driver/compress.c
index 073bbe2afc8b95..51134352c5d2fb 100644
--- a/clang/test/Driver/compress.c
+++ b/clang/test/Driver/compress.c
@@ -1,5 +1,9 @@
+// XFAIL: system-aix
+
 // REQUIRES: zlib
 
+; XFAIL: target={{.*}}-aix{{.*}}
+
 // RUN: %clang -### -fintegrated-as -Wa,-compress-debug-sections -c %s 2>&1 | FileCheck -check-prefix CHECK-_COMPRESS_DEBUG_SECTIONS %s
 // CHECK-_COMPRESS_DEBUG_SECTIONS: "-compress-debug-sections"
 

Co-authored-by: David Tenty <daltenty.dev@gmail.com>
@azhan92 azhan92 requested a review from daltenty April 3, 2024 13:50
Copy link
Member

@daltenty daltenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

// REQUIRES: zlib

// XFAIL: target={{.*}}-aix{{.*}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

system-aix is sufficient and // XFAIL: target={{.*}}-aix{{.*}} is uneeded?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems correct, I've removed // XFAIL: target={{.*}}-aix{{.*}}

@azhan92 azhan92 changed the title XFAIL clang/Driver/compress.c on AIX XFAIL clang/Driver/test/compress.c on AIX Apr 4, 2024
@azhan92 azhan92 requested a review from MaskRay April 10, 2024 17:53
@MaskRay
Copy link
Member

MaskRay commented Apr 11, 2024

Can you edit the description to state which command fails on AIX?

These tests all contain -### to stop after clangDriver completes. And clang --target=powerpc-ibm-aix -fintegrated-as -Wa,-compress-debug-sections -c a.c '-###' seems to work for me.

We have other tests that rely on the integrated assembler, so I'd be surprised if this is the only test failing on AIX.

@azhan92
Copy link
Contributor Author

azhan92 commented Apr 11, 2024

Can you edit the description to state which command fails on AIX?

These tests all contain -### to stop after clangDriver completes. And clang --target=powerpc-ibm-aix -fintegrated-as -Wa,-compress-debug-sections -c a.c '-###' seems to work for me.

We have other tests that rely on the integrated assembler, so I'd be surprised if this is the only test failing on AIX.

@MaskRay, it should be this command that's failing: RUN: %clang -### -fintegrated-as -gz -c %s 2>&1 | FileCheck -check-prefix CHECK-OPT_GZ %s. I also added it to the description. The other tests that were failing due to the integrated assembler were XFAIL'd in this commit, but it seems like they missed this test since the buildbot doesn't run it (since it requires zlib).

@MaskRay
Copy link
Member

MaskRay commented Apr 12, 2024

Thanks for the information. CHECK-OPT_GZ is shared by two RUN lines. The failure is due to -x assembler.

clang '-###' -c --target=powerpc64-ibm-aix -fintegrated-as -gz -x assembler compress.c  # warning: argument unused during compilation: '-gz' [-Wunused-command-line-argument]

Since this is unsupported, UNSUPPORTED: is more suitable than XFAIL: system-aix.

@daltenty daltenty merged commit f981d86 into llvm:main Apr 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants