-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XFAIL clang/Driver/test/compress.c on AIX #87269
Conversation
@llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: None (azhan92) ChangesThis PR XFAIL's Full diff: https://github.com/llvm/llvm-project/pull/87269.diff 1 Files Affected:
diff --git a/clang/test/Driver/compress.c b/clang/test/Driver/compress.c
index 073bbe2afc8b95..51134352c5d2fb 100644
--- a/clang/test/Driver/compress.c
+++ b/clang/test/Driver/compress.c
@@ -1,5 +1,9 @@
+// XFAIL: system-aix
+
// REQUIRES: zlib
+; XFAIL: target={{.*}}-aix{{.*}}
+
// RUN: %clang -### -fintegrated-as -Wa,-compress-debug-sections -c %s 2>&1 | FileCheck -check-prefix CHECK-_COMPRESS_DEBUG_SECTIONS %s
// CHECK-_COMPRESS_DEBUG_SECTIONS: "-compress-debug-sections"
|
Co-authored-by: David Tenty <daltenty.dev@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
clang/test/Driver/compress.c
Outdated
// REQUIRES: zlib | ||
|
||
// XFAIL: target={{.*}}-aix{{.*}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
system-aix is sufficient and // XFAIL: target={{.*}}-aix{{.*}}
is uneeded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems correct, I've removed // XFAIL: target={{.*}}-aix{{.*}}
Can you edit the description to state which command fails on AIX? These tests all contain We have other tests that rely on the integrated assembler, so I'd be surprised if this is the only test failing on AIX. |
@MaskRay, it should be this command that's failing: |
Thanks for the information.
Since this is unsupported, |
This PR XFAIL's
clang/Driver/compress.c
on AIX since it requires the LLVM integrated assembler / assembly parser support, which is not available on AIX.