[BoundsSafety] Minor fixes on counted_by

[rapidsna]

DeclRef to field must be marked as LValue to be consistent with how the field decl will be evaluated.

T->desugar() is unnecessary to call ->isArrayType().

[llvmbot]

@llvm/pr-subscribers-clang

Author: Yeoul Na (rapidsna)

Changes

DeclRef to field must be marked as LValue to be consistent with how the field decl will be evaluated.

T->desugar() is unnecessary to call ->isArrayType().

---

Full diff: https://github.com/llvm/llvm-project/pull/87559.diff

2 Files Affected:

• (modified) clang/lib/AST/TypePrinter.cpp (+2-2)
• (modified) clang/lib/Sema/SemaExpr.cpp (+1-1)

diff --git a/clang/lib/AST/TypePrinter.cpp b/clang/lib/AST/TypePrinter.cpp
index 9d551ff83151fd..954ea004108975 100644
--- a/clang/lib/AST/TypePrinter.cpp
+++ b/clang/lib/AST/TypePrinter.cpp
@@ -1762,14 +1762,14 @@ static void printCountAttributedImpl(const CountAttributedType *T,
 void TypePrinter::printCountAttributedBefore(const CountAttributedType *T,
                                              raw_ostream &OS) {
   printBefore(T->desugar(), OS);
-  if (!T->desugar()->isArrayType())
+  if (!T->isArrayType())
     printCountAttributedImpl(T, OS, Policy);
 }
 
 void TypePrinter::printCountAttributedAfter(const CountAttributedType *T,
                                             raw_ostream &OS) {
   printAfter(T->desugar(), OS);
-  if (T->desugar()->isArrayType())
+  if (T->isArrayType())
     printCountAttributedImpl(T, OS, Policy);
 }
 
diff --git a/clang/lib/Sema/SemaExpr.cpp b/clang/lib/Sema/SemaExpr.cpp
index 80b4257d9d83ed..6b2eb245d58263 100644
--- a/clang/lib/Sema/SemaExpr.cpp
+++ b/clang/lib/Sema/SemaExpr.cpp
@@ -2751,7 +2751,7 @@ Sema::ActOnIdExpression(Scope *S, CXXScopeSpec &SS,
         QualType type = VD->getType().getNonReferenceType();
         // This will eventually be translated into MemberExpr upon
         // the use of instantiated struct fields.
-        return BuildDeclRefExpr(VD, type, VK_PRValue, NameLoc);
+        return BuildDeclRefExpr(VD, type, VK_LValue, NameLoc);
       }
     }
   }

[delcypher]

LGTM