Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unused-includes][ADT] Don't include DJB.h as it's not used. NFC. #88211

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

vsapsai
Copy link
Collaborator

@vsapsai vsapsai commented Apr 9, 2024

StringMap uses xxHash instead of DJB.

@llvmbot
Copy link
Collaborator

llvmbot commented Apr 9, 2024

@llvm/pr-subscribers-llvm-adt

Author: Volodymyr Sapsai (vsapsai)

Changes

StringMap uses xxHash instead of DJB.


Full diff: https://github.com/llvm/llvm-project/pull/88211.diff

1 Files Affected:

  • (modified) llvm/include/llvm/ADT/StringMap.h (-1)
diff --git a/llvm/include/llvm/ADT/StringMap.h b/llvm/include/llvm/ADT/StringMap.h
index 32e611467ac58e..453d91349e3585 100644
--- a/llvm/include/llvm/ADT/StringMap.h
+++ b/llvm/include/llvm/ADT/StringMap.h
@@ -17,7 +17,6 @@
 #include "llvm/ADT/StringMapEntry.h"
 #include "llvm/ADT/iterator.h"
 #include "llvm/Support/AllocatorBase.h"
-#include "llvm/Support/DJB.h"
 #include "llvm/Support/PointerLikeTypeTraits.h"
 #include <initializer_list>
 #include <iterator>

@vsapsai
Copy link
Collaborator Author

vsapsai commented Apr 9, 2024

DJB.h header include was added in 9a4a4c3

@vsapsai
Copy link
Collaborator Author

vsapsai commented Apr 11, 2024

Buildkite reports

Total Discovered Tests: 36933
  Skipped          :    30 (0.08%)
  Unsupported      :   243 (0.66%)
  Passed           : 36624 (99.16%)
  Expectedly Failed:    36 (0.10%)

but still decided the build has failed.

Don't know how to re-trigger the tests.

Copy link
Collaborator

@dwblaikie dwblaikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch! Must've been a holdover from the original version of the patch.

@vsapsai
Copy link
Collaborator Author

vsapsai commented Apr 13, 2024

Thanks for the catch! Must've been a holdover from the original version of the patch.

Thanks for taking a look that's not an upcoming use of DJB hashing.

@vsapsai vsapsai merged commit f172bfc into llvm:main Apr 13, 2024
5 of 6 checks passed
@vsapsai vsapsai deleted the remove-unused-includes/stringmap-djb branch April 13, 2024 01:27
bazuzi pushed a commit to bazuzi/llvm-project that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants