Reduce binary size of the Microsoft demangler #89454
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls the body of
llvm::ms_demangle::ArenaAllocator::allocArray
andllvm::ms_demangle::ArenaAllocator::alloc
into a commonallocAlignedBuffer
function. In my testing this reduces the overall binary size ofLLVMDemangle.lib
by 6kb and has a negligible impact on performance.The
addNode(std::max(AllocUnit, Size));
being pulled into the common function retains the same behaviour as before asSize
will always be< AllocUnit
when allocating a single object.