Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lld,test] fix few filecheck annotation typos #92238

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

klensy
Copy link
Contributor

@klensy klensy commented May 15, 2024

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot
Copy link

llvmbot commented May 15, 2024

@llvm/pr-subscribers-lld-macho

@llvm/pr-subscribers-lld

Author: klensy (klensy)

Changes

Plus few places where i don't know how to resolve issues:

# REEXPORT: Exports trie:
# REEXPORT-NEXT: [re-export] _tlv [per-thread] (from libdefault)
# REEXPORT-NEXT: [re-export] _keep_globl (from libdefault)
# REEXPORT-NEXT: [re-export] _undef (from unknown)
unknown prefix

# RUN: --check-prefix=EMPTY-TRIE
unused prefix

https://github.com/llvm/llvm-project/blame/421862f8e4ffddf57e210a205984a0ee39c57d96/lld/test/ELF/riscv-gp.s#L19-L21 unknown prefix

https://github.com/llvm/llvm-project/blame/421862f8e4ffddf57e210a205984a0ee39c57d96/lld/test/ELF/ppc64-reloc-addr.s#L9 unkown prefix HEXBE
https://github.com/llvm/llvm-project/blame/421862f8e4ffddf57e210a205984a0ee39c57d96/lld/test/ELF/ppc64-toc-relax-ifunc.s#L24-L26 unknown prefox REL
https://github.com/llvm/llvm-project/blame/main/lld/test/ELF/ppc64-pcrel-call-to-extern.s unknown prefixes 'SEC-OG', 'REL-NEXT-OG'
https://github.com/llvm/llvm-project/blame/421862f8e4ffddf57e210a205984a0ee39c57d96/lld/test/ELF/ppc32-reloc-rel.s#L25-L26 unknown prefix HEX
https://github.com/llvm/llvm-project/blame/d187005cad8c2cb7d44ba3dd6b01c5f0e4c14ae7/lld/test/ELF/mips-tls-hilo.s#L31-L39 unknown prefix SO
https://github.com/llvm/llvm-project/blame/main/lld/test/ELF/arm-exidx-shared.s prefix uses filecheck command as part of name: CHECK-EXTAB-NEXT, ambiguity


Full diff: https://github.com/llvm/llvm-project/pull/92238.diff

2 Files Affected:

  • (modified) lld/test/MachO/install-name.s (+1-1)
  • (modified) lld/test/MachO/objc-methname.s (+1-1)
diff --git a/lld/test/MachO/install-name.s b/lld/test/MachO/install-name.s
index 1cf675e278bfa..c419c6ca1f951 100644
--- a/lld/test/MachO/install-name.s
+++ b/lld/test/MachO/install-name.s
@@ -31,7 +31,7 @@
 
 # ID:          cmd LC_ID_DYLIB
 # ID-NEXT: cmdsize
-# LID-NEXT:   name foo
+# ID-NEXT:   name foo
 
 .globl _main
 _main:
diff --git a/lld/test/MachO/objc-methname.s b/lld/test/MachO/objc-methname.s
index afc137eac8c21..3d06472971c80 100644
--- a/lld/test/MachO/objc-methname.s
+++ b/lld/test/MachO/objc-methname.s
@@ -16,7 +16,7 @@
 
 # CSTRING: Contents of (__TEXT,__cstring) section
 # CSTRING-NEXT: existing-cstring
-# CSTIRNG-EMPTY:
+# CSTRING-EMPTY:
 
 # METHNAME: Contents of (__TEXT,__objc_methname) section
 # METHNAME-NEXT: existing_methname

@MaskRay MaskRay merged commit f97f039 into llvm:main May 15, 2024
5 checks passed
Copy link

@klensy Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

@MaskRay
Copy link
Member

MaskRay commented May 15, 2024

I merged this PR before I realized that you are using a users.noreply.github.com email address.

Note: the consensus is to avoid them: https://discourse.llvm.org/t/hidden-emails-on-github-should-we-do-something-about-it/74223/32

@MaskRay
Copy link
Member

MaskRay commented May 15, 2024

Plus few places where i don't know how to resolve issues:

Thanks for these links. I'll try fixing them.

MaskRay added a commit that referenced this pull request May 15, 2024
Most violations are stale and should be removed while a few can be
adjusted.

Reported at #92238
qiaojbao pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Jun 5, 2024
…26627c1f0

Local branch amd-gfx ce12662 Merged main:ee765b0c94df7e636d9739216b1646d3a2d3b5db into amd-gfx:cf4a0e80e87c
Remote branch main f97f039 [lld,test] Fix few FileCheck annotation typos (llvm#92238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants