Skip to content

Conversation

ojhunt
Copy link
Contributor

@ojhunt ojhunt commented May 31, 2024

Minor correction to match current API

ojhunt and others added 2 commits May 30, 2024 17:37
…-tables, and VTTs.

This also implements the ptrauth_vtable_pointer attribute to allow
overriding the default ptrauth schema for vtable pointers.

Co-Authored-By: John McCall <rjmccall@apple.com>
Minor correction to match current API
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels May 31, 2024
@llvmbot
Copy link
Member

llvmbot commented May 31, 2024

@llvm/pr-subscribers-clang

Author: Oliver Hunt (ojhunt)

Changes

Minor correction to match current API


Full diff: https://github.com/llvm/llvm-project/pull/93984.diff

1 Files Affected:

  • (modified) clang/lib/Sema/SemaDeclAttr.cpp (+1-1)
diff --git a/clang/lib/Sema/SemaDeclAttr.cpp b/clang/lib/Sema/SemaDeclAttr.cpp
index 82c4a3c866458..e9a867ff67ba1 100644
--- a/clang/lib/Sema/SemaDeclAttr.cpp
+++ b/clang/lib/Sema/SemaDeclAttr.cpp
@@ -9246,7 +9246,7 @@ static void handleVTablePointerAuthentication(Sema &S, Decl *D,
       AL.setInvalid();
     }
 
-    if (!AL.isArgExpr(3) || !S.checkUInt32Argument(AL, AL.getArgAsExpr(3),
+    if (!AL.isArgExpr(3) || !checkUInt32Argument(S, AL, AL.getArgAsExpr(3),
                                                    customDiscriminationValue)) {
       S.Diag(AL.getLoc(), diag::err_invalid_custom_discrimination);
       AL.setInvalid();

Copy link

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Discourse for more information.

@ahmedbougacha ahmedbougacha force-pushed the users/ahmedbougacha/ptrauth-cpp-vtables branch from 89bc142 to 3523eaf Compare May 31, 2024 18:52
@ahmedbougacha ahmedbougacha deleted the users/ojhunt/ptrauth-cpp-vtables branch May 31, 2024 18:55
@ahmedbougacha ahmedbougacha removed clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants