Skip to content

Conversation

RoseZhang03
Copy link
Contributor

@RoseZhang03 RoseZhang03 commented Jun 20, 2024

Function header files for epoll_pwait and epoll_pwait2 have const modifier on
SigSetPtrType in function signature, but the linux.td file does not
reflect that.

.td file located in libc/spec/linux.td
epoll functions located in libc/src/sys/epoll

Headerfiles for epoll_pwait and epoll_pwait2 have const modifier on
SigSetPtrType in function signature, but the linux.td file does not
reflect that.

.td file located in libc/spec/linux.td
epoll functions located in libc/src/sys/epoll
@llvmbot
Copy link
Member

llvmbot commented Jun 20, 2024

@llvm/pr-subscribers-libc

Author: None (RoseZhang03)

Changes

Headerfiles for epoll_pwait and epoll_pwait2 have const modifier on
SigSetPtrType in function signature, but the linux.td file does not
reflect that.

.td file located in libc/spec/linux.td
epoll functions located in libc/src/sys/epoll


Full diff: https://github.com/llvm/llvm-project/pull/96252.diff

1 Files Affected:

  • (modified) libc/spec/linux.td (+2-2)
diff --git a/libc/spec/linux.td b/libc/spec/linux.td
index f91f55ddac784..82630ff413c73 100644
--- a/libc/spec/linux.td
+++ b/libc/spec/linux.td
@@ -205,7 +205,7 @@ def Linux : StandardSpec<"Linux"> {
             ArgSpec<StructEpollEventPtr>,
             ArgSpec<IntType>,
             ArgSpec<IntType>,
-            ArgSpec<SigSetPtrType>
+            ArgSpec<ConstSigSetPtrType>
           ]
         >,
         FunctionSpec<
@@ -216,7 +216,7 @@ def Linux : StandardSpec<"Linux"> {
             ArgSpec<StructEpollEventPtr>,
             ArgSpec<IntType>,
             ArgSpec<ConstStructTimeSpecPtr>,
-            ArgSpec<SigSetPtrType>
+            ArgSpec<ConstSigSetPtrType>
           ]
         >,
       ]  // Functions

Copy link
Contributor

@michaelrj-google michaelrj-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RoseZhang03 RoseZhang03 merged commit f0b9309 into llvm:main Jun 21, 2024
@RoseZhang03 RoseZhang03 deleted the rosezhang6 branch June 21, 2024 18:31
AlexisPerry pushed a commit to llvm-project-tlp/llvm-project that referenced this pull request Jul 9, 2024
Function header files for epoll_pwait and epoll_pwait2 have const
modifier on
SigSetPtrType in function signature, but the linux.td file does not
reflect that.

.td file located in libc/spec/linux.td
epoll functions located in libc/src/sys/epoll
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants