[libc] cmake configruation for newhdrgen #98257
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this is a draft to get more input/reviews - tests have been done on dirent and ctype to see matching results as old headergen - added entrypoints filtering within the script
aaryanshukla
requested review from
petrhosek,
frobtech,
amykhuang,
lntue,
michaelrj-google and
RoseZhang03
lntue
reviewed
Jul 10, 2024
There was a problem hiding this comment.
Overall looks good, but wait for @jhuber6 to weigh in on the GPU side
| DEPENDS ${yaml_file} ${def_file} ${fq_data_files} | ||
| COMMENT "Generating header ${ADD_YAML_HDR_GEN_HDR} from ${yaml_file} and ${def_file}" | ||
| ) | ||
|
|
There was a problem hiding this comment.
it looks like in the old version the GPU build had an extra condition here that created a second set of headers that only contained the function prototypes. @jhuber6 do you still need that?
- able to generate all headers with new headergen (waiting on landing for assert.yaml) - fixed bugs within yaml files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old headergen