Skip to content

Update the project dependencies for the lldb-remote-linux builders. #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

Update the project dependencies for the lldb-remote-linux builders. #574

merged 1 commit into from
Aug 27, 2025

Conversation

vvereschaka
Copy link
Contributor

Add additional dependencies with the libc++/libc++abi/libunwind and compiler-rt libraries.

Also removed unaffected LLDB_CAN_USE_LLDB_SERVER options.

@vvereschaka
Update the project dependencies for the lldb-remote-linux builders.
f77a3d0 
Add additional dependencies with the libc++/libc++abi/libunwind and
compiler-rt libraries.

Also removed unaffected LLDB_CAN_USE_LLDB_SERVER options.
@vvereschaka vvereschaka self-assigned this Aug 26, 2025
gkistanova
gkistanova approved these changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@gkistanova gkistanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vvereschaka vvereschaka merged commit 3160d9f into llvm:main Aug 27, 2025
3 checks passed
@slydiman
Copy link
Contributor

slydiman commented Sep 2, 2025

libcxx, libcxxabi and libunwind are not valid projects for LLVM. Note llvm-project/llvm/CMakeLists.txt contains
set(LLVM_ALL_PROJECTS "bolt;clang;clang-tools-extra;compiler-rt;cross-project-tests;libclc;lld;lldb;mlir;openmp;polly")
It seems we need to specify enable_projects with valid projects instead of enable_projects="auto" but keep depends_on_projects with the full list to trigger builds by a scheduler.

@vvereschaka vvereschaka mentioned this pull request Sep 2, 2025
Merged
vvereschaka added a commit that referenced this pull request Sep 2, 2025
@vvereschaka
Revert "Update the project dependencies for the lldb-remote-linux bui…
ebcba44 
…lders." (#588)

Reverts #574

Causes failures during the configuration step for the
lldb-remote-linux-* builders.
vvereschaka added a commit to vvereschaka/llvm-zorg that referenced this pull request Sep 25, 2025
@vvereschaka
Revert "Update the project dependencies for the lldb-remote-linux bui…
3d0b820 
…lders." (llvm#588)

Reverts llvm#574

Causes failures during the configuration step for the
lldb-remote-linux-* builders.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkistanova gkistanova gkistanova approved these changes

@andreil99 andreil99 Awaiting requested review from andreil99

@slydiman slydiman Awaiting requested review from slydiman

Assignees

@vvereschaka vvereschaka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vvereschaka @slydiman @gkistanova