Skip to content

[FxImporter] make FxImporter to fit python<=3.9 #2802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 26, 2024
Merged

[FxImporter] make FxImporter to fit python<=3.9 #2802

merged 2 commits into from
Jan 26, 2024

Conversation

qingyunqu
Copy link
Collaborator

@qingyunqu qingyunqu commented Jan 25, 2024 •
edited
Loading

As that torch with py3.9 is also used widely.

stellaraccident
stellaraccident approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@stellaraccident stellaraccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've left a suggestion that I think is more Pythonic. Up to you to use it or apply what you have.

@qingyunqu qingyunqu merged commit e73c536 into llvm:main Jan 26, 2024
zjgarvey pushed a commit to zjgarvey/torch-mlir that referenced this pull request Jan 29, 2024
@qingyunqu @zjgarvey
[FxImporter] make FxImporter to fit python<=3.9 (llvm#2802)
df53133 
As that torch with py3.9 is also used widely.
@stellaraccident stellaraccident mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellaraccident stellaraccident stellaraccident approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qingyunqu @stellaraccident