Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Create new web app for Trophy Hunter #38

Closed
11 tasks
lmachens opened this issue Jan 4, 2019 · 4 comments
Closed
11 tasks

Create new web app for Trophy Hunter #38

lmachens opened this issue Jan 4, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@lmachens
Copy link
Owner

lmachens commented Jan 4, 2019

TL;DR
Create a web app based on our API, Next.js and maybe MaterialUI.

The problem
We have a very limited web app which only shows matches and ranking.
https://www.loltrophyhunter.com/match/EUW1/3863024196/24688273
It is the same like in the app and doesn't look good in the browser.

The technology
Our new api makes it possible to read from our database and fetch data from the Riot API.
Example: https://www.th.gl/api/trophies?platformId=euw1&matchId=3795861223&summonerId=30118891

I prepared the setup based on Next.js and serverless deployment.
See https://github.com/lmachens/trophy-hunter/tree/master/src/www

Why Next.js?
It fits perfectly into our serverless architecture and allows easy scaling and developing.

Details:

Design-wise I am open for ideas.
It could get inspired by https://play.overwolf.com/trophy-hunter/ or our app https://www.overwolf.com/app/trophy_hunter-trophy_hunter.

I am very familiar with MaterialUI and want to be able to maintain the web app later.

The tasks

First of all, thank you that you are reading this.
For me it is important to have a good communication and speak about ideas and issues.
In the past I had bad experiences with other devs who created one huge pull request which was impossible to review. Please show me some of your work and speak about your ideas.
If you work on this task, please create small pull requests.

First step:

Second step (not important right now -> only to get a feeling what we want to do later):

@Rayth
Copy link
Contributor

Rayth commented Jan 5, 2019

What exactly do you need the web-app to do?

@lmachens
Copy link
Owner Author

lmachens commented Jan 5, 2019

@Rayth I will finish the requirements soon

@Rayth
Copy link
Contributor

Rayth commented Jan 5, 2019

@Rayth I will finish the requirements soon

Cool will keep posted. Web-development is my specialty (more specifically PHP development)

@lmachens
Copy link
Owner Author

We hired a designer to create a new design for this project which includes Adobe XD specs for
the landing, profile and match results pages.
In the meantime I prepare the use of our api in #96.
After the design is done, it should be easy to convert it to React components.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants