Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad french translation #35

Merged
merged 10 commits into from
Jun 12, 2023
Merged

Ad french translation #35

merged 10 commits into from
Jun 12, 2023

Conversation

ColonelMoutarde
Copy link
Contributor

No description provided.

Copy link
Owner

@lmarzen lmarzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my comments.

platformio/src/locales/locale_fr_FR.inc Outdated Show resolved Hide resolved
platformio/src/locales/locale_fr_FR.inc Outdated Show resolved Hide resolved
platformio/src/locales/locale_fr_FR.inc Outdated Show resolved Hide resolved
platformio/src/locales/locale_fr_FR.inc Outdated Show resolved Hide resolved
platformio/src/locales/locale_fr_FR.inc Outdated Show resolved Hide resolved
platformio/src/locales/locale_fr_FR.inc Outdated Show resolved Hide resolved
platformio/src/locales/locale_fr_FR.inc Outdated Show resolved Hide resolved
platformio/src/locales/locale_fr_FR.inc Outdated Show resolved Hide resolved
ColonelMoutarde and others added 8 commits June 12, 2023 10:36
Co-authored-by: Luke Marzen <98473324+lmarzen@users.noreply.github.com>
Co-authored-by: Luke Marzen <98473324+lmarzen@users.noreply.github.com>
Co-authored-by: Luke Marzen <98473324+lmarzen@users.noreply.github.com>
Co-authored-by: Luke Marzen <98473324+lmarzen@users.noreply.github.com>
Co-authored-by: Luke Marzen <98473324+lmarzen@users.noreply.github.com>
Co-authored-by: Luke Marzen <98473324+lmarzen@users.noreply.github.com>
Co-authored-by: Luke Marzen <98473324+lmarzen@users.noreply.github.com>
Copy link
Owner

@lmarzen lmarzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing

platformio/src/locales/locale_fr_FR.inc Outdated Show resolved Hide resolved
Co-authored-by: Luke Marzen <98473324+lmarzen@users.noreply.github.com>
Copy link
Owner

@lmarzen lmarzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lmarzen lmarzen merged commit 9c252d0 into lmarzen:main Jun 12, 2023
@lmarzen
Copy link
Owner

lmarzen commented Jun 12, 2023

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants