Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some sniffs are deprecated #39

Closed
legendik opened this issue May 4, 2020 · 1 comment · Fixed by #47
Closed

Some sniffs are deprecated #39

legendik opened this issue May 4, 2020 · 1 comment · Fixed by #47
Milestone
3.0

Comments

@legendik
Copy link

legendik commented May 4, 2020

Following sniffs are deprecated. We should use https://github.com/Slamdunk/phpstan-extensions instead.

Notice: Sniff "Symplify\CodingStandard\Sniffs\Naming\ClassNameSuffixByParentSniff" is deprecated. Use "Symplify\CodingStandard\Rules\ClassNameRespectsParentSuffixRule" instead in /Users/legendik/work/employee-persistor/vendor/symplify/coding-standard/src/Sniffs/Naming/ClassNameSuffixByParentSniff.php on line 57
PHP Notice:  Sniff "Symplify\CodingStandard\Sniffs\Naming\ClassNameSuffixByParentSniff" is deprecated. Use "Symplify\CodingStandard\Rules\ClassNameRespectsParentSuffixRule" instead in /Users/legendik/work/employee-persistor/vendor/symplify/coding-standard/src/Sniffs/Naming/ClassNameSuffixByParentSniff.php on line 57

Notice: Sniff "Symplify\CodingStandard\Sniffs\Naming\AbstractClassNameSniff" is deprecated. Use "https://github.com/Slamdunk/phpstan-extensions" instead in /Users/legendik/work/employee-persistor/vendor/symplify/coding-standard/src/Sniffs/Naming/AbstractClassNameSniff.php on line 36
PHP Notice:  Sniff "Symplify\CodingStandard\Sniffs\Naming\AbstractClassNameSniff" is deprecated. Use "https://github.com/Slamdunk/phpstan-extensions" instead in /Users/legendik/work/employee-persistor/vendor/symplify/coding-standard/src/Sniffs/Naming/AbstractClassNameSniff.php on line 36

Notice: Sniff "Symplify\CodingStandard\Sniffs\Naming\InterfaceNameSniff" is deprecated. Use "https://github.com/Slamdunk/phpstan-extensions" instead in /Users/legendik/work/employee-persistor/vendor/symplify/coding-standard/src/Sniffs/Naming/InterfaceNameSniff.php on line 36
PHP Notice:  Sniff "Symplify\CodingStandard\Sniffs\Naming\InterfaceNameSniff" is deprecated. Use "https://github.com/Slamdunk/phpstan-extensions" instead in /Users/legendik/work/employee-persistor/vendor/symplify/coding-standard/src/Sniffs/Naming/InterfaceNameSniff.php on line 36

Notice: Sniff "Symplify\CodingStandard\Sniffs\Naming\TraitNameSniff" is deprecated. Use "https://github.com/Slamdunk/phpstan-extensions" instead in /Users/legendik/work/employee-persistor/vendor/symplify/coding-standard/src/Sniffs/Naming/TraitNameSniff.php on line 36
PHP Notice:  Sniff "Symplify\CodingStandard\Sniffs\Naming\TraitNameSniff" is deprecated. Use "https://github.com/Slamdunk/phpstan-extensions" instead in /Users/legendik/work/employee-persistor/vendor/symplify/coding-standard/src/Sniffs/Naming/TraitNameSniff.php on line 36
@OndraM
Copy link
Member

OndraM commented May 4, 2020

Well, we can't simply use Slamdunk/phpstan-extensions instead, because these are rules for PHPStan, not for easy coding standard 🤔. I will have a look what could be done there.

This is Tomas's explanation why this is happening:
https://www.tomasvotruba.com/blog/2020/05/04/how-to-upgrade-to-symplify-8-from-sniffs-to-phpstan-rules/

See also deprecated-packages/symplify#1906

OndraM added a commit to OndraM/php-coding-standard that referenced this issue May 4, 2020
@OndraM
Avoid deprecation errors from symplify/coding-standard (see lmc-eu#39)
d98b0f7
@OndraM OndraM mentioned this issue May 4, 2020
Merged
OndraM added a commit that referenced this issue May 4, 2020
@OndraM
Avoid deprecation errors from symplify/coding-standard (see #39)
6e91e57
OndraM added a commit to OndraM/php-coding-standard that referenced this issue May 4, 2020
@OndraM
Avoid deprecation errors from symplify/coding-standard (see lmc-eu#39)
e4bdf12
OndraM added a commit that referenced this issue May 4, 2020
@OndraM
Avoid deprecation errors from symplify/coding-standard (see #39)
28576e7
This was referenced Nov 26, 2020
Closed
Merged
@OndraM OndraM added this to the 3.0 milestone Nov 27, 2020
@OndraM OndraM closed this as completed in #47 Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
2 participants
@OndraM @legendik