Skip to content

Conversation

OndraM
Copy link
Contributor

@OndraM OndraM commented Jan 4, 2022

Fixes #72 .

@janbarasek Could you please try it on your codebase?

In require-dev of composer.json:

    "lmc/coding-standard": "dev-fix/type-error",

@janbarasek
Copy link

Thank you, it now generates this diff:

    ---------- begin diff ----------
--- Original
+++ New
@@ -32,7 +32,7 @@
             }
         }
 
-        return (string) $refererUri->withQuery(http_build_query($cleanQueryParts));
+        return (string) $refererUri->withQuery(http_build_query($cleanQueryParts, '', '&'));
     }
 
     public function invalidGridFilterSettings(): void

    ----------- end diff -----------

@OndraM OndraM requested a review from janbarasek January 4, 2022 14:14
@OndraM OndraM merged commit b424f7a into main Jan 4, 2022
@OndraM OndraM deleted the fix/type-error branch January 4, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] SpecifyArgSeparatorFixer require type error argument
2 participants