Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: SpecifyArgSeparatorFixer type error in PHP 7.4+ #73

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Conversation

OndraM
Copy link
Member

@OndraM OndraM commented Jan 4, 2022

Fixes #72 .

@janbarasek Could you please try it on your codebase?

In require-dev of composer.json:

    "lmc/coding-standard": "dev-fix/type-error",

@janbarasek
Copy link

Thank you, it now generates this diff:

    ---------- begin diff ----------
--- Original
+++ New
@@ -32,7 +32,7 @@
             }
         }
 
-        return (string) $refererUri->withQuery(http_build_query($cleanQueryParts));
+        return (string) $refererUri->withQuery(http_build_query($cleanQueryParts, '', '&'));
     }
 
     public function invalidGridFilterSettings(): void

    ----------- end diff -----------

@OndraM OndraM requested a review from janbarasek January 4, 2022 14:14
@OndraM OndraM merged commit b424f7a into main Jan 4, 2022
@OndraM OndraM deleted the fix/type-error branch January 4, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] SpecifyArgSeparatorFixer require type error argument
2 participants