Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port sparse matrix support from umap #16

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Conversation

tomwhite
Copy link
Collaborator

@tomwhite tomwhite commented Apr 3, 2019

Fixes #6

@lmcinnes
Copy link
Owner

lmcinnes commented Apr 5, 2019

Thanks for this. You may want to check the 0.4dev branch of umap however, as it has extra distance functions in the sparse case, and a few other potentially useful changes. Alternatively we can get this merged and then worry about the extra stuff from 0.4dev in a later update.

@tomwhite
Copy link
Collaborator Author

tomwhite commented Apr 5, 2019

I think we can look at 0.4dev separately.

(I just fixed conflicts and rebased.)

@lmcinnes
Copy link
Owner

lmcinnes commented Apr 5, 2019

Excellent, thank you!

@lmcinnes lmcinnes merged commit 8e24077 into lmcinnes:master Apr 5, 2019
@tomwhite
Copy link
Collaborator Author

@lmcinnes regarding 0.4dev, I just had a quick look and it seems fairly divergent from master. Is the plan to sync it with master - or vice versa?

@lmcinnes
Copy link
Owner

I potentially need to resync master into it at some point, but eventually it will get merged into master.

@tomwhite
Copy link
Collaborator Author

OK. In that case I think it makes sense to wait until it's merged into master before porting any changes over to pynndescent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sparse matrix support
2 participants