Allow a low memory option for index construction #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlmelville
requested changes
Sep 7, 2019
There was a problem hiding this comment.
LGTM except for my question about the tried default arguments.
Unrelated to the current changes, but sparse_nndescent.py imports numpy and tau_rand but doesn't seem to do anything with them.
test_nn_decent_with_n_jobs_minus_one fails for me, but I see it's not on master yet either, so I'm not going to worry about that for this PR.
|
Thanks for the suggestions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits out the internals of of the NNdescent loop to either use or skip the use of the
triedcache depending on whether the user selects alow_memoryoption which defaults toFalse.