Minimizer.params is always the same instance as the params used to construct the Minimizer, closes #174. #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfaff
force-pushed
the
mini_obj_state
branch
from
da87904
to
edfe538
Compare
|
The first commit obviously fails the tests I've just added. But the second should pass, as I've made the amendments to minimizer.py |
Merged
|
I believe this issue is addressed as of the merge of #230. Is it OK to close this? |
|
I'm pretty sure that #230 makes this PR impossible to merge. If there are issues regarding values or identity of input and output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danielballan to kick this PR off, I've modified the test_copy_params.py file, which was added to test #56.
I've added an extra test
test_copy_params_Minimizer, that checks if theMinimizer.paramsattribute is the same instance as theparamsobject used to construct theMinimizerin the first place.Without the "fix" I get the following error:
FAIL: test_copy_params_Minimizer (test_copy_params.test_copy_params)
Traceback (most recent call last):
File "/Users/anz/Documents/Andy/programming/lmfit-py/tests/test_copy_params.py", line 80, in test_copy_params_Minimizer
assert_(params is fitter.params)
File "/Users/anz/Documents/Andy/programming/dev2/lib/python2.7/site-packages/numpy/testing/utils.py", line 53, in assert_
raise AssertionError(smsg)
AssertionError