TST: Fix broken tests and make Travis run all tests.

[danielballan]

No description provided.

[danielballan]

Travis is not currently running any tests; it is only building the docs. We need it to run the tests, especially with all the fast-paced changes, so we are alerted when a PR contains a breaking change.

I put aside test_make_paras_and_func.py by renaming it with a leading underscore, so for now it will be ignored. If we want to support wrap.py, that test suite needs attention. I gave it a quick look but I couldn't understand the issue.

All other tests pass.

[danielballan]

Hmm. There's one test still failing. Matt, can you make anything of this Traceback?

[newville]

have you merged with Till's fix for a similar problem from a couple days ago, commit ec8e7d0 ?

[danielballan]

Yes.

[newville]

I'd like to merge this. Should we remove the test_ci.py here?

[danielballan]

Yes. It's better to have some test coverage, especially on the ever-changing Model class, than none. Let's come back around to test_ci.py soon. I'll remove it momentarily, and you can merge if Travis passes.

[danielballan]

Now all 27 tests pass on my system, but one is still failing on Travis. We're getting a NotImplementError related to Nelder-Mead. (Full Traceback) I suspect the version of numpy/scipy we are using may differ from mine.

It would be helpful if someone else could run

/lmfit-py~$ nosetests/tests

and see if they can reproduce.

[newville]

Hi Dan,

Yes, scalar_minimize() is relatively new to scipy (0.11) -- a year old or
so. This is why the older fmin() etc functions were in minimizer.py.
Adding test of mini.HAS_SCALAR_MIN might be sufficient.

[danielballan]

Done. I refactored them into separate tests, so the Nelder-Mead one can raise nose.SkipTest if need be -- better than silently passing it.

[danielballan]

Oh, I misunderstood. Either they all need to skipped or (it seems) none. Well, this should work. If Travis passes, merge.

[danielballan]

All tests pass in Python 2. There are some parts of model.py that were not Python 3 compatible -- now fixed. Weirdly, something with peak_fit is breaking in Python 3 only. Help?

[newville]

The docs now build for me, and Travis passes for both Python 2 and 3.
This PR now seems out-of-date... is it moot or should it be re-made?

[danielballan]

Once you merge #74, I'll rebase these commits onto master. We should be able to merge it without that, but I'd like to see this actually pass on Travis before we merge on the off-chance there is still a lingering Travis-specific failure.

[newville]

Committed. I think it is good to go, but thought Till might want a chance to modify it.

[newville]

merged (by hand)

[danielballan]

peak_fit is still unhappy, and it looks like I missed for py3-incompatible dictionary stuff. I'll take care of the latter.

[newville]

OK thanks -- I wanted to get this merged before cutting way down on coding over the holidays.

[newville]

I think I got the bug for test_algebraic_constraints2...

[danielballan]

OK, so you merged them into master? I rebased this branch, run-tests-on-travis onto the current master. We'll see what Travis thinks....

[danielballan]

Phew! That's a pass. Merge this monster, and let us never speak of it again. :- )

[newville]

Thanks!