parse_response now handles 504 Gateway Timeout errors #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it's missing coverage, but that's to be expected. I don't think there's any easy way to mock out a 504 to ensure that it works, so can you just add raise error.APIConnectionError(resp.content or resp.reason, # pragma: no cover
resp.content, resp.status_code, resp) |
|
@robinjoseph08 Done |
|
Awesome, thanks a ton! I'll push a new version today 👍 |
robinjoseph08
added a commit
that referenced
this pull request
Feb 5, 2016
parse_response now handles 504 Gateway Timeout errors
|
Version 2.24 has been released! |
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #103