Refactors letter examples to be just a create letters from csv example #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage remained the same at 100.0% when pulling 67e60dc128b0df95963447d17c6aad2e0aa44341 on letters-from-csv-example into 1295230 on master. |
sjl2
force-pushed
the
letters-from-csv-example
branch
from
67e60dc to
91723aa
Compare
1 similar comment
| color = True | ||
| ) | ||
| except Exception, e: | ||
| print "Error: " + str(e) + " in " + str(row) |
There was a problem hiding this comment.
The errors should also be being logged to errors.csv. Right now we just open the file descriptor and close it. We used to be writing to it when the address verification failed. We want to make sure we log them since they could fail due to rate limits, file dimensions, etc.
|
LGTM after the comments are addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Remove the verify and create letters example with just create letters example
Why: Each product will have its example to demonstrate use