Checks from csv example #112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage remained the same at 100.0% when pulling 977b57067093c588a5c6505a253a0800fb6a934b on checks-from-csv-example into 1295230 on master. |
sjl2
force-pushed
the
checks-from-csv-example
branch
from
977b570 to
68f5d04
Compare
sjl2
force-pushed
the
checks-from-csv-example
branch
from
68f5d04 to
0404db4
Compare
| # Sphinx documentation | ||
| docs/_build/ | ||
|
|
||
| #Generated Files |
There was a problem hiding this comment.
nit: add space after start of comment
| logo = 'https://s3-us-west-2.amazonaws.com/lob-assets/lob_check_logo.png' | ||
| ) | ||
| except Exception, e: | ||
| print "Error: " + str(e) + " in " + str(row) |
There was a problem hiding this comment.
Same comment from @dmlittle regarding writing to errors.csv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Add checks from csv example
Why: Each product should have its own example for each wrapper