Skip to content

test(api-key): remove lob api key from tests and examples #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 28, 2018
Merged

test(api-key): remove lob api key from tests and examples #153

merged 2 commits into from
Dec 28, 2018

Conversation

kylekwong
Copy link
Contributor

What

  • Removes all lob api keys from source code
  • Updates testing instructions in README

Why

No need to expose API keys

kylekwong
kylekwong commented Dec 28, 2018
View reviewed changes
arkadiyt
arkadiyt approved these changes Dec 28, 2018
View reviewed changes
Copy link

@arkadiyt arkadiyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo Ami's comments

marklee22
marklee22 approved these changes Dec 28, 2018
View reviewed changes
Copy link

@marklee22 marklee22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 to Ami's' suggestion.

@coveralls
Copy link

coveralls commented Dec 28, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 300341d on remove-test-key into fc19aad on master.

@kylekwong kylekwong merged commit e7ff4c1 into master Dec 28, 2018
@kylekwong kylekwong deleted the remove-test-key branch December 28, 2018 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@ami ami ami left review comments

@marklee22 marklee22 marklee22 approved these changes

@arkadiyt arkadiyt arkadiyt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@kylekwong kylekwong

Labels
Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kylekwong @coveralls @marklee22 @arkadiyt @ami