Add SAM #23
Merged
Add SAM #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amrit
commented
Jul 30, 2014
amrit
commented
- Added support for areas and routes
- Fixed bad jobs test
|
Coverage increased (+0.19%) when pulling 5d0e08a02a76b10d796f771cc848e0c72fd1184b on add-sam into 96bc424 on master. |
|
Can we get this to 100% coverage? @pon |
|
Ready for review @pon @leore @bsiddiqui |
|
Looks like URL file upload works does local upload? Can you add a test for local upload? |
|
Test added. |
|
LGMT |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.