Break out examples into readable/runnable chunks #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you should rename bankAccount.py to check.py, other than that LGTM |
examples/job.py
Outdated
There was a problem hiding this comment.
you have spacing after = signs in some places and not in other places - think you should make this consistent
|
LGTM after style fix |
|
Renamed file, good catch @pon |
|
@lob/api-engineering-lobsters made CR fixes |
|
coverage is at 99 |
graysonchao
pushed a commit
that referenced
this pull request
Oct 20, 2014
Break out examples into readable/runnable chunks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lob/api-engineering-lobsters