feat(examples): example updates #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lob/api-engineering-team |
|
LGTM - just clarify that comment |
russelltaylor05
force-pushed
the
examples
branch
from
22d6653 to
17653fa
Compare
|
Gracias! @elnaz wanna take a look? |
examples/README.md
Outdated
There was a problem hiding this comment.
...showing how to validate and cleanse...
...using Lob**'s** [Address...
There was a problem hiding this comment.
oh man my proof reading is horrible
There was a problem hiding this comment.
Don't sweat it. Proofreading skills are a curse.
|
This is great. Just a couple of small notes then LGTM. |
|
Good catches @elnaz. You're a CR veteran. |
russelltaylor05
force-pushed
the
examples
branch
from
17653fa to
fb14935
Compare
russelltaylor05
force-pushed
the
examples
branch
from
fb14935 to
bcd75dc
Compare
russelltaylor05
added a commit
that referenced
this pull request
Apr 10, 2015
feat(examples): example updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.