Skip to content

Conversation

elnaz
Copy link
Contributor

@elnaz elnaz commented Apr 18, 2015

@lob/api-engineering-team

#67

@leore
Copy link
Contributor

leore commented Apr 18, 2015

build failing due to new verify. Need to use a verified bank account to send check .

@elnaz elnaz force-pushed the bank_account_verify branch from d795992 to b78da19 Compare April 20, 2015 17:56
@elnaz
Copy link
Contributor Author

elnaz commented Apr 20, 2015

I fixed the unverified bank in the check tests. The automatic build failed but when I retried the build through Travis directly, it passed: https://travis-ci.org/lob/lob-python/builds/59281092

So this is ready for review @pon @leore

@pon
Copy link
Contributor

pon commented Apr 20, 2015

LGTM

@leore
Copy link
Contributor

leore commented Apr 20, 2015

Any idea why the buld is failing?

@pon
Copy link
Contributor

pon commented Apr 20, 2015

Latest is passing: https://travis-ci.org/lob/lob-python/builds/59281092

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens when you try to verify an account that has already been verified?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It errors

On Mon, Apr 20, 2015 at 12:38 PM, Leore Avidar notifications@github.com
wrote:

@@ -47,7 +47,23 @@
print "======================================================="
print "\n"

-# Creating a Check using the previously created bank account
+# Verifying a Bank Account with the microdeposit amounts

what happens when you try to verify an account that has already been verified?

Reply to this email directly or view it on GitHub:
https://github.com/lob/lob-python/pull/64/files#r28721371

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pon @elnaz having the verify process in the check example might be weird if you cannot verify a bank over and over again

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this will work then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will - the bank account is created above

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh yep.

@leore
Copy link
Contributor

leore commented Apr 20, 2015

LGTM

@leore
Copy link
Contributor

leore commented Apr 20, 2015

Let create a new version

leore added a commit that referenced this pull request Apr 20, 2015
feat(bankAccounts): added support for verifying accounts
@leore leore merged commit cdae39a into master Apr 20, 2015
@leore leore deleted the bank_account_verify branch April 20, 2015 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants