-
Notifications
You must be signed in to change notification settings - Fork 45
feat(bankAccounts): added support for verifying accounts #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
build failing due to new verify. Need to use a verified bank account to send check . |
d795992
to
b78da19
Compare
I fixed the unverified bank in the check tests. The automatic build failed but when I retried the build through Travis directly, it passed: https://travis-ci.org/lob/lob-python/builds/59281092 |
LGTM |
Any idea why the buld is failing? |
Latest is passing: https://travis-ci.org/lob/lob-python/builds/59281092 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens when you try to verify an account that has already been verified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It errors
On Mon, Apr 20, 2015 at 12:38 PM, Leore Avidar notifications@github.com
wrote:
@@ -47,7 +47,23 @@
print "======================================================="
print "\n"-# Creating a Check using the previously created bank account
+# Verifying a Bank Account with the microdeposit amountswhat happens when you try to verify an account that has already been verified?
Reply to this email directly or view it on GitHub:
https://github.com/lob/lob-python/pull/64/files#r28721371
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think this will work then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will - the bank account is created above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh yep.
LGTM |
Let create a new version |
feat(bankAccounts): added support for verifying accounts
@lob/api-engineering-team
#67