feat(examples): making easier to follow examples #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/README.md
Outdated
There was a problem hiding this comment.
I think the example should point to the master copy of Lob. Not the package version.
There was a problem hiding this comment.
It is pointing to the master copy. I was wrong yesterday.
They do still need to install the package once to use 'import lob'.
There was a problem hiding this comment.
So what he's saying is that we should be referencing the local code rather than importing lob from pip. This prevents any issues with their installed version differing from the downloaded version. So the examples will always work.
|
LGTM |
1 similar comment
|
LGTM |
dmlittle
force-pushed
the
improve_examples_onboarding
branch
from
375e344 to
ef610d7
Compare
dmlittle
force-pushed
the
improve_examples_onboarding
branch
from
ef610d7 to
350597a
Compare
mgartner
added a commit
that referenced
this pull request
Jun 9, 2015
feat(examples): making easier to follow examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@elnaz @leore @pon
updated python wrapper examples. renamed folders structures and flushed out the readme