Skip to content

Conversation

neelk07
Copy link
Contributor

@neelk07 neelk07 commented Jun 19, 2015

What: an example to verify and create letters

Why: allow customer to try out a test script that would take their csv file and generate letters for billing

Details:

@russelltaylor05 @pon @mgartner @robinjoseph08 @elnaz

@russelltaylor05
Copy link
Contributor

to be consistent with the other wrappers, lets name the example directory csv_letter_mail_merge

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to "Bill for {name}"

@pon pon force-pushed the verify-and-create-letters-from-csv branch from fa15fd2 to b593092 Compare June 22, 2015 17:40
@neelk07
Copy link
Contributor Author

neelk07 commented Jun 22, 2015

@russelltaylor05

I made the suggested changes, let me know if you notice anything else

@russelltaylor05
Copy link
Contributor

LGTM

@elnaz
Copy link
Contributor

elnaz commented Jun 23, 2015

Except now the folder name is inconsistent with the other python example folders. I would vote for /verify_and_create_letters_from_csv since it's more clear but if we stick with /csv_letter_mail_merge then we should also change the other two example folders.

@elnaz
Copy link
Contributor

elnaz commented Jun 23, 2015

@neelk07 could you also update the README to mention this new example?

@pon pon force-pushed the verify-and-create-letters-from-csv branch from b593092 to 44f16c2 Compare June 23, 2015 23:43
@pon pon force-pushed the verify-and-create-letters-from-csv branch from 44f16c2 to 4ca489a Compare June 24, 2015 00:04
@neelk07
Copy link
Contributor Author

neelk07 commented Jun 24, 2015

@russelltaylor05 @elnaz @pon @mgartner

updated the READMEs

@russelltaylor05
Copy link
Contributor

@elnaz @dmlittle @neelk07
Whatever you guys think is the best naming for the examples folders is fine with me. But, please work with @dmlittle to make sure the Node examples have the same names. It will be confusing to readers if I send them to a github example that has different names in different wrappers.

@elnaz
Copy link
Contributor

elnaz commented Jun 24, 2015

@russelltaylor05 I agree. @dmlittle could you update the node examples folders to have the same names as the python ones?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify and create ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm

@elnaz
Copy link
Contributor

elnaz commented Jun 24, 2015

LGTM pending small readme header change
Good work neel!

neelk07 added a commit that referenced this pull request Jun 24, 2015
feat(examples): added example to verify and create letters
@neelk07 neelk07 merged commit aaf226f into master Jun 24, 2015
@neelk07 neelk07 deleted the verify-and-create-letters-from-csv branch June 24, 2015 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants