-
Notifications
You must be signed in to change notification settings - Fork 45
feat(examples): added example to verify and create letters #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
to be consistent with the other wrappers, lets name the example directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change this to "Bill for {name}"
fa15fd2
to
b593092
Compare
I made the suggested changes, let me know if you notice anything else |
LGTM |
Except now the folder name is inconsistent with the other python example folders. I would vote for /verify_and_create_letters_from_csv since it's more clear but if we stick with /csv_letter_mail_merge then we should also change the other two example folders. |
@neelk07 could you also update the README to mention this new example? |
b593092
to
44f16c2
Compare
44f16c2
to
4ca489a
Compare
@russelltaylor05 @elnaz @pon @mgartner updated the READMEs |
@elnaz @dmlittle @neelk07 |
@russelltaylor05 I agree. @dmlittle could you update the node examples folders to have the same names as the python ones? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify and create ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm
LGTM pending small readme header change |
feat(examples): added example to verify and create letters
What: an example to verify and create letters
Why: allow customer to try out a test script that would take their csv file and generate letters for billing
Details:
examples/verify_and_create_letters_from_csv/
folderpython letter.py input.csv
@russelltaylor05 @pon @mgartner @robinjoseph08 @elnaz