feat(params): single object list parameters serialized as arrays #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There should be a test for this, right? To ensure it's working correctly. |
dmlittle
force-pushed
the
list-parameters-as-array
branch
from
11b2949 to
b311ce1
Compare
|
LGTM pending build |
dmlittle
force-pushed
the
list-parameters-as-array
branch
from
b311ce1 to
a0fe553
Compare
|
LGTM |
dmlittle
pushed a commit
that referenced
this pull request
Jul 1, 2015
feat(params): single object list parameters serialized as arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: list parameters are serialized as arrays to the API endpoint
Why: allows the wrapper to use array parameters
Detail:
lob.Address.list(include=['total_count'])@pon @mgartner @elnaz @robinjoseph08 @neelk07