Skip to content

Conversation

dmlittle
Copy link
Contributor

What:

  • Add object support as arguments to ListableAPIResources
  • Allows wrapper to use metadata = { 'campaign' : 'NEWYORK2015' } on .list() methods
  • Fixes Support querying on metadata #86

@dmlittle
Copy link
Contributor Author

@elnaz @robinjoseph08 @mgartner @brianseitel
I'm pretty sure all the tests pass (at least they do locally), but I don't have proper credentials to re-run the tests on Travis CI. Could someone re-run them? Thanks!

@leore
Copy link
Contributor

leore commented Sep 30, 2015

I just rebuilt it and it failed again.

@robinjoseph08
Copy link
Contributor

Yeah looks like Travis changed something in the way it builds it because even an older build that used to pass now fails. We'll take a closer look soon.

Thanks for taking care of this @dmlittle! 👍

@elnaz
Copy link
Contributor

elnaz commented Oct 2, 2015

I tweeted at Travis about the issue. In the meantime, I think we can go ahead and merge this because we know the build is failing because of travis. Thanks @dmlittle!

elnaz added a commit that referenced this pull request Oct 2, 2015
fix(metadata): add metadata support to ListableAPIResource
@elnaz elnaz merged commit 8fd3625 into lob:master Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants